Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EL8 support and claim compatibility #527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

optiz0r
Copy link

@optiz0r optiz0r commented Jul 4, 2022

Pull Request (PR) description

Rework of #484 against latest master branch.

The version of corosync uses a cli parameter instead of an environment variable to point at the config file to be tested. Without this change, the env var is ignored and the config_validate_cmd command always checks the real config file location before installing the candidate file. On a new build, this will fail because the real config file does not yet exist. When being updated, the real config file is checked, instead of the candidate file, so an invalid change might be falsely reported as acceptable and lead to an outage.

This change overrides the config validate command on el8 to use the correct syntax.

It also lists el8 as a compatible OS in the module metadata, since the module is currently being used with this patch in production.

This Pull Request (PR) fixes the following issues

Fixes #526
Obsoletes #484

@optiz0r optiz0r added the enhancement New feature or request label Jul 4, 2022
@zilchms
Copy link
Contributor

zilchms commented Apr 10, 2024

@optiz0r , can you rebase on the current master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for EL8
2 participants