[Bug] Check parsed JSON receipt if it contains the purchaseToken field for Google Play #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to determine if the platform type of the receipt is Google Play, there are two cases:
iap.validate
is an object, then the code checks ifreceipt.signature
orreceipt.purchaseToken
exists.iap.validate
is a string, then the code first parses the receipt into an object (calledparsed
), then it is supposed to check ifparsed.signature
orparsed.purchaseToken
exists.However, for the second condition the code never checks
parsed.purchaseToken
, instead checking whetherreceipt.purchaseToken
exists twice.As a result, when a Google Play receipt string that uses service account for validation is passed into
iap.validate
, the package interprets it as an Amazon receipt since the receipt will not containparsed.signature
. It only containsparsed.purchaseToken
, which is never checked.