New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
totalResource calculation error in proportion plugin #3444
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
@Monokaix @lowang-bh Hi, Could you help confirm this issue? thx~ |
bysph
changed the title
totalResource calculation error when setting nodeSelector
totalResource calculation error in proportion plugin
Apr 28, 2024
You mean what node-selector specified? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description:
I found proportion plugin has some issues:
These issues may result in an inflated
deserved
value for all queues, potentially rendering theguarantee
ineffective.Description of case 1 (node label isolation scenarios):
Expected Behavior:
The total resource of the queue needs to be recalculated, rather than being calculated uniformly based on the total resources of the entire cluster.
Steps to Reproduce:
for example of case 2:
ssn.TotalResource
or the list ofssn.Nodes
Additional Information:
Volcano Version: v1.8.2
Kubernetes Version: v1.19.3
Proposed Solution:
The total resources of the queue need to be recalculated as follows:
And the "deserved" value also needs to be recalculated:
nodegroup
, then calculate proportionally......
The text was updated successfully, but these errors were encountered: