export the logs of Volcano components when the e2e test workflow fails #3438
Conversation
volcano-sh-bot
added
the
size/S
hack/run-e2e-kind.sh
Outdated
| @@ -72,6 +72,30 @@ function generate-log { | |||
| kubectl logs deployment/${CLUSTER_NAME}-scheduler -n ${NAMESPACE} > volcano-scheduler.log | |||
| } | |||
|
|
|||
| function show-log() { | |||
| if [ -f volcano-admission.log ]; then | |||
There was a problem hiding this comment.
the logic of printing volcano component is similar, whether it's better to do it with a loop.
There was a problem hiding this comment.
the logic of printing volcano component is similar, whether it's better to do it with a loop.
good idea
|
/lgtm |
|
/assign @Thor-wl please take a look |
|
Hi, @william-wang , please merge this pr with high-priority. thanks. cc @Monokaix |
|
/priority important-soon |
|
@lowang-bh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
volcano-sh-bot
added
the
priority/important-soon
| for log_file in "${log_files[@]}"; do | ||
| if [ -f "$log_file" ]; then | ||
| echo "Showing ${log_file}..." | ||
| cat "$log_file" |
There was a problem hiding this comment.
This seems that will print lots of logs.
|
/lgtm |
Signed-off-by: Panos Woo <panoswoo@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh, william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Resolves #3429