Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the Devices interface add a scoring function #3381

Open
ZDWWWWW opened this issue Apr 2, 2024 · 4 comments
Open

Can the Devices interface add a scoring function #3381

ZDWWWWW opened this issue Apr 2, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ZDWWWWW
Copy link

ZDWWWWW commented Apr 2, 2024

What would you like to be added:

For the Devices interface add a scoring function.

Why is this needed:

I can learn how to implement my own device from the following design documents.
https://github.com/volcano-sh/volcano/blob/master/docs/design/device-sharing.md
https://github.com/volcano-sh/volcano/blob/master/docs/user-guide/how_to_use_vgpu.md

The current devices interface only provides the FilterNode function, which will predicate suitable nodes for me. For my current scenario, it is necessary to select the best node from the suitable nodes, and the current devices interface does not seem to provide such a function. So I want to know if adding a scoring function to the devices interface is necessary.

@ZDWWWWW ZDWWWWW added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 2, 2024
@Monokaix
Copy link
Member

There is already a pr #3210 enhanced this, and @archlitchi is working on this: )

@ZDWWWWW
Copy link
Author

ZDWWWWW commented Apr 11, 2024

There is already a pr #3210 enhanced this, and @archlitchi is working on this: )

cooool~ thank you 😙

@Monokaix
Copy link
Member

/kind question

@volcano-sh-bot
Copy link
Contributor

@Monokaix: The label(s) kind/question cannot be applied. These labels are supported: ``

In response to this:

/kind question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants