Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage check pipeline #3344

Open
lowang-bh opened this issue Mar 9, 2024 · 3 comments
Open

Add code coverage check pipeline #3344

lowang-bh opened this issue Mar 9, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lowang-bh
Copy link
Member

What would you like to be added:

Please add a github pipeline to check code coverage.

Why is this needed:

Make sure a commit has necessary UTs and UTs are effective to cover its relative changes。
@lowang-bh lowang-bh added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2024
@lowang-bh
Copy link
Member Author

lowang-bh commented Mar 9, 2024 •
edited

/assign @william-wang @Monokaix

@Monokaix
Copy link
Member

It's a good idea, but this may increase the threshold for contributors to submit PR.

@lowang-bh
Copy link
Member Author

lowang-bh commented Mar 12, 2024 •
edited

It's a good idea, but this may increase the threshold for contributors to submit PR.

Write relative UTs is the basic skill for a developer. And sometimes new PR will break old fixes without UTs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Monokaix @lowang-bh