Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Remove direct dependency k8s.io/kubernetes #1281

Closed
gaocegege opened this issue Feb 1, 2021 · 10 comments
Closed

[feature] Remove direct dependency k8s.io/kubernetes #1281

gaocegege opened this issue Feb 1, 2021 · 10 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gaocegege
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

kubernetes/kubernetes#90358 (comment)

It affects lots of downstream projects like tf-operator.

What you expected to happen:

Do not depend on k8s.io/kubernetes directly.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Volcano Version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 1, 2021
@Thor-wl
Copy link
Member

Thor-wl commented Feb 1, 2021

I'll take it into consideration together when update volcano to k8s v1.19
/cc @Thor-wl

@k82cn
Copy link
Member

k82cn commented Feb 3, 2021

xref #1270

@shinytang6
Copy link
Member

shinytang6 commented Mar 15, 2021

Can we remove the k8s.io/kubernetes dependency firstly? Otherwise, this will block downstream projects references currently. @k82cn @Thor-wl

@k82cn
Copy link
Member

k82cn commented Mar 16, 2021

Can we remove the k8s.io/kubernetes dependency firstly? Otherwise, this will block downstream projects references currently.

hm... we import k8s.io/kubernetes for the algorithms of default scheduler; https://github.com/volcano-sh/apis is used for downstream projects.

@stale
Copy link

stale bot commented Jun 14, 2021

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2021
@stale
Copy link

stale bot commented Aug 13, 2021

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 13, 2021
@adamwoolhether
Copy link

This is becoming a problem when i recently updated some of my deps.

k8s.io/kubernetes isn't supposed to be imported, read here: kubernetes/kubernetes#90358 (comment)

@Thor-wl Thor-wl reopened this Mar 7, 2022
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2022
@Thor-wl Thor-wl added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 7, 2022
@Thor-wl
Copy link
Member

Thor-wl commented Mar 7, 2022

This is becoming a problem when i recently updated some of my deps.

k8s.io/kubernetes isn't supposed to be imported, read here: kubernetes/kubernetes#90358 (comment)

I've met the same problem when update the dependencies. The way I solved it is that add the indirect dependency and the version to the replace module and then try again.

@stale
Copy link

stale bot commented Jun 11, 2022

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2022
@stale
Copy link

stale bot commented Aug 10, 2022

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants