Fix kernel version control for proc_dir_entry #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The struct proc_dir_entry is used in the plugin linux_check_fop. The struct was defined in module.c only in kernel versions greater than 3.13, causing an error when running linux_check_fop on systems with older kernel versions. I noticed that this struct hasn't changed at all between kernel versions 3.10 and 3.13, so we can make this plugin support more versions with this fix. This change is relatively significant because many distributions are shipped with a 3.10.~ kernel (CentOS 7 and RHEL 7, among others).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct proc_dir_entry is used in the plugin linux_check_fop.
The struct was defined in module.c only in kernel versions greater than 3.13, causing an error when running linux_check_fop on systems with older kernel versions.
I noticed that this struct hasn't changed at all between kernel versions 3.10 and 3.13, so we can make this plugin support more versions with this fix.
This change is relatively significant because many distributions are shipped with a 3.10.~ kernel (CentOS 7 and RHEL 7, among others).