Implement (Un-)marshalText for Decimal and NullDecimal #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenafamo, please have a look. Thanks! |
MJacred
force-pushed
the
feature/unmarshal_text
branch
from
51f18ce
to
52f74eb
Compare
MJacred
force-pushed
the
feature/unmarshal_text
branch
from
52f74eb
to
4676800
Compare
MJacred
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnmarshalText is required for parsing a text/csv file. Without, the code uses decimal directly and ends in a nil pointer exception because decimal.Big is nil on
scan