fixed pg claim dlc crash #224
Conversation
|
I just don't understand why you replaced the single quotation mark with a double quotation mark generally generated unnecessary changes |
|
that was my vs code addon, forget to disable it here |
|
Thanks, but please undo the unrelated syntactic changes first, otherwise it's hard to read what changed semantically. |
prime-gaming.js
Outdated
| @@ -387,8 +403,9 @@ try { | |||
| } finally { | |||
| await db.write(); // write out json db | |||
| if (notify_games.length) { // list should only include claimed games | |||
|
|
|||
| notify(`prime-gaming (${user}):<br>${html_game_list(notify_games)}`); | ||
| } | ||
| } | ||
| if (page.video()) console.log('Recorded video:', await page.video().path()) | ||
| await context.close(); | ||
| await context.close(); |
| console.error(' Missing account linking:', unlinked_store, url); | ||
| dlc_unlinked[unlinked_store] ??= []; | ||
| dlc_unlinked[unlinked_store].push(title); | ||
| unlinked_store = await linkAccountButton.getAttribute("aria-label"); |
prime-gaming.js
Outdated
| dlc_unlinked[unlinked_store].push(title); | ||
| unlinked_store = await linkAccountButton.getAttribute("aria-label"); | ||
| console.debug(` Not able to claim. ${unlinked_store}`); | ||
| // console.debug(' LinkAccountButton label:', unlinked_store); |
There was a problem hiding this comment.
Indentation seems messed up down from here.
|
Ok, better to read now. The only two relevant changes I see so far are changing the locator here: https://github.com/vogler/free-games-claimer/pull/224/files#diff-e35468b40bc179e267a0d50f7aa118eeaf03dcf676da75ac50a251b575c7c9bdR328-R330 The rest is commented out and partially duplicated code. |
|
Yea thats about it. i commented stuff out because that code not works with the new one so far and i have only worked on the loot claiming yet. This needs to be looked at. That should be a temp replacement for the old stuff. i mentioned that i ran out of offers to test so its commented until someone could approve https://github.com/vogler/free-games-claimer/pull/224/files#diff-e35468b40bc179e267a0d50f7aa118eeaf03dcf676da75ac50a251b575c7c9bdR375-R385 |
|
Kudos, SonarCloud Quality Gate passed!
|
code wasn't working for the new layout. swapped a few lines to collect loot again but there is still a bit to do.
i marked a line with //TODO (line 525) where the bot should post the code as console.log but i ran out of prime offers to test out the code. Also there was a bug with the unlinked stores that i just fixed temporarily by removing some other stuff about it (around line 521)