Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #20

wants to merge 1 commit into from

Conversation

rajeev1689
Copy link

@rajeev1689 rajeev1689 commented Nov 1, 2018 •
edited

Customers do not want the password on CLI as it gets stored in history
Signed-off-by: rajarora189@gmail.com

@vmwclabot
Copy link
Member

@rajeev1689, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@rajeev1689
Copy link
Author

@rajeev1689, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: rajarora189@gmail.com

@rajeev1689
Copy link
Author

Signed-off-by: rajarora189@gmail.com

kais66
kais66 reviewed Nov 2, 2018
View reviewed changes
README.md
docker run --name nsx-t-install -d \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /home/concourse:/home/concourse \
-e CONCOURSE_URL="http://10.33.75.99:8080" \
-e EXTERNAL_DNS="10.33.38.1" \
-e IMAGE_WEBSERVER_PORT=40001 \
-e VMWARE_USER='<myvmware_user_email>' \
-e VMWARE_PASSWORD='<myvmware_password>' \
-e VMWARE_PASSWORD="$password" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think single quotes are required here since password may contain special characters

@kais66
Copy link
Contributor

kais66 commented Nov 2, 2018

Thanks for this update

@Dyanngg Dyanngg force-pushed the master branch 2 times, most recently from aaf6712 to 19c7adb Compare April 25, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kais66 kais66 kais66 left review comments

Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajeev1689 @vmwclabot @kais66