Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Control 000067 xPath code #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leebeck3
Copy link

@leebeck3 leebeck3 commented Apr 3, 2024

was throwing an error when ran

Tested on Aria 8.16 with Inspec 4.18
tests included:

  1. commenting out ErrorReportValve
  2. changing showServerInfo to true
  3. removing showServerInfo

known/potential issues:
report valve will still match so long as ErrorReportValve, shouldn't be an issue unless typos happen.
doesn't scan for every host value, assumed it wasn't needed for this could be fixed with a count or something similar:

its(["count(//Host[not(Valve[contains(@className, 'ErrorReportValve')])]) | //Host[Valve[contains(@className, 'ErrorReportValve')]/@showServerInfo != 'false'])"]) { should cmp [0] }

@vmwclabot
Copy link
Member

@leebeck3, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@leebeck3, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@leebeck3, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide a valid address

@vmwclabot
Copy link
Member

@leebeck3, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@freddyfeelgood
Copy link
Contributor

@leebeck3 Can you provide the details of the ruby error you're getting? Also, do you get the same error if you upgrade your inspec version and retry?

@leebeck3
Copy link
Author

yep, here you go:

Unknown XML object received (Array): []

No way to elevate my version currently.

@vmwclabot
Copy link
Member

@leebeck3, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants