Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

220 abx project templates must be updated #268

Merged
merged 2 commits into from
May 27, 2024
Merged

220 abx project templates must be updated #268

merged 2 commits into from
May 27, 2024

Conversation

mtopchieva
Copy link
Contributor

Description

Updated the package.json template for generating abx actions so that it contains more of the recently implemented parameters: base, memoryLimitMb, timeoutSec, provider and abx (inputSecrets, inputConstants, etc.)

Checklist

  • I have updated CHANGELOG.md with a short summary of the changes introduced

Testing

Updated the package.json template for generating abx actions so that it contains more of the recently implemented parameters.

Release Notes

Updated the package.json template for generating abx actions so that it contains the parameters: base, memoryLimitMb, timeoutSec, provider and abx (inputSecrets, inputConstants, etc.)

@mtopchieva mtopchieva requested a review from a team as a code owner April 29, 2024 09:44
@mtopchieva mtopchieva linked an issue Apr 29, 2024 that may be closed by this pull request
ABX project templates must be updated #220
Closed
@vmwclabot
Copy link
Member

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@mtopchieva mtopchieva force-pushed the 220-abx-project-templates-must-be-updated branch from ec5faa4 to 492d13d Compare April 29, 2024 09:51
@vmwclabot
Copy link
Member

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@mtopchieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@mtopchieva mtopchieva force-pushed the 220-abx-project-templates-must-be-updated branch from 92785ee to 0877a1f Compare April 29, 2024 12:41
@mtopchieva
Closes Issue 220 updating package.json template for abx actions
f8b242c 
Signed-off-by: Maria Topchieva <mtopchieva@vmware.com>
@mtopchieva mtopchieva force-pushed the 220-abx-project-templates-must-be-updated branch from 63c7c0f to f8b242c Compare April 29, 2024 12:44
@akantchev
[Task N/A] Merge with main.
7eae003 
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@VenelinBakalov
Copy link
Contributor

@mtopchieva sorry for the delay. could you update the remaining merge conflicts and then we can merge this as well

Michaelpalacce
Michaelpalacce approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akantchev akantchev merged commit e3000c1 into main May 27, 2024
12 checks passed
@VenelinBakalov VenelinBakalov deleted the 220-abx-project-templates-must-be-updated branch May 27, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinBakalov VenelinBakalov VenelinBakalov left review comments

@Michaelpalacce Michaelpalacce Michaelpalacce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ABX project templates must be updated
5 participants
@mtopchieva @vmwclabot @VenelinBakalov @Michaelpalacce @akantchev