Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABX project templates must be updated #220

Closed
vsuddya opened this issue Jan 12, 2024 · 8 comments · Fixed by #268
Closed

ABX project templates must be updated #220

vsuddya opened this issue Jan 12, 2024 · 8 comments · Fixed by #268
Assignees
Labels
abx-archetype enhancement New feature or request java Pull requests that update Java code

Comments

@vsuddya
Copy link
Contributor

vsuddya commented Jan 12, 2024

Description

Recently were introduced new parameters:

  • memoryLimitMb
  • timeoutSec
  • inputSecrets
  • inputConstants
  • provider
    etc

ABX project templates must be updated to ensure consistency.

@Michaelpalacce Michaelpalacce added enhancement New feature or request java Pull requests that update Java code abx-archetype labels Jan 15, 2024
@mtopchieva mtopchieva self-assigned this Jan 23, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@mtopchieva
Copy link
Contributor

mtopchieva commented Feb 26, 2024

The abx project template is updated. But an improvement can be made, so that the 'runtime' property is populated with the correct value taken from the 'mvn archetype:generate' command's runtime input (nodejs/python/powershell). This needed additional research and development, and I was moved to another task before being able to close the issue.

@github-actions github-actions bot removed the Stale label Feb 27, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 28, 2024
@VenelinBakalov
Copy link
Contributor

@mtopchieva do you think you will have availability to check back on this task once you finish with your ongoing task?
Also, could you add as a comment here the PR which is adding the template update

@mtopchieva
Copy link
Contributor

Hi @VenelinBakalov, unfortunately I will not manage to work on the issue in the forthcoming 2 weeks at least. There is not an open PR because the implementation is not complete.

@github-actions github-actions bot removed the Stale label Mar 29, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 28, 2024
@mtopchieva mtopchieva linked a pull request Apr 29, 2024 that will close this issue
1 task
@VenelinBakalov
Copy link
Contributor

Still active, there is PR opened

@VenelinBakalov
Copy link
Contributor

@mtopchieva I saw you had a suggestion for improvement in the comments above. If this is still a possible improvement, could you open a github issue with the suggestion here: https://github.com/vmware/build-tools-for-vmware-aria/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abx-archetype enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants