This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
Fix Docker CE 17.03.x installation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify ansible/roles/docker/tasks/redhat.yml to use command module to run yum command directly. This allows use of setopts=obsoletes=0, which fixes installation of Docker CE 17.03.x on CentOS/RHEL. Ubuntu is not affected. Signed-off-by: Scott Lowe <scott.lowe@scottlowe.org>
|
BTW, I have verified that this issue does not affect Ubuntu; hence, this PR includes commits affecting the CentOS/RHEL playbooks only. |
detiber
reviewed
Aug 29, 2018
|
|
||
| - name: install Docker CE if docker binary is not present | ||
| command: "yum install -y --setopt=obsoletes=0 docker-ce-selinux-{{docker_redhat_version}} docker-ce-{{docker_redhat_version}}" | ||
| when: docker_present.stat.exists == False |
There was a problem hiding this comment.
Can you add a comment to point to the upstream issue: moby/moby#33930 and remove the commented out task?
There was a problem hiding this comment.
Addressed via commit 0474adb
Remove commented tasks. Add comments explaining use of tasks and reasons. Added link to source issue in Moby repo. Signed-off-by: Scott Lowe <scott.lowe@scottlowe.org>
detiber
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues with some dependencies, Docker CE 17.03 installation on CentOS/RHEL 7 can't be accomplished using standard
yummodule. This PR fixes the installation by using acommandmodule to runyumdirectly.Addresses issue #72 (see conversation there for links to dependencies issues referenced above).