Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rootless podman functionality #419

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tbelway
Copy link

@tbelway tbelway commented Dec 25, 2023

Compatibility with rootless podman added.

gravity-sync Outdated Show resolved Hide resolved
@tbelway
Copy link
Author

tbelway commented Dec 31, 2023

I have it working with no errors atm. Let me know if you need anything else.

@vmstan
Copy link
Owner

vmstan commented Jan 7, 2024

Thanks for this, I need to get some time to properly test this before merging.

@tbelway
Copy link
Author

tbelway commented Jan 11, 2024

I have it working with no errors atm. Let me know if you need anything else.

Thanks for this, I need to get some time to properly test this before merging.

No worries bud. I am also hella sleep deprived with my kids, so just let me know if there's anything that doesn't play nice with your tests and I'll correct. I have it working for me, it plays seamless with fedora server and almalinux but for some reason I sometimes get gravity.db corruptions on microos, but I had that before I was using gravity sync so I am pretty sure it has to do with something else :)

I had it syncing across 3 pihole instances in a loop fashion, which is not resilient in the case of one going down, so if I ever get some free time maybe I'll look at a spoke model...

@RhavinX
Copy link

RhavinX commented Feb 12, 2024

Any updates on getting this tested/merged? I run rootless podman and would really like this functionality.
As it stands on the machine running rootless podman:

✓ Podman installation has been detected
! There is no Podman container of Pi-hole running
✗ Pi-hole was not found on this system
» Status Report
✗ 1 critical issue(s) prevent successful deployment



CONTAINER ID  IMAGE                            COMMAND      CREATED         STATUS                   PORTS                                                                                                       NAMES
aa74381baf23  docker.io/mvance/unbound:latest  /unbound.sh  21 minutes ago  Up 21 minutes (healthy)  0.0.0.0:53->53/tcp, 0.0.0.0:80->80/tcp, 0.0.0.0:5335->5335/tcp, 0.0.0.0:53->53/udp, 0.0.0.0:5335->5335/udp  unbound
12c193d96ca1  docker.io/pihole/pihole:latest                21 minutes ago  Up 21 minutes (healthy)  0.0.0.0:53->53/tcp, 0.0.0.0:80->80/tcp, 0.0.0.0:5335->5335/tcp, 0.0.0.0:53->53/udp, 0.0.0.0:5335->5335/udp  pihole

@tbelway
Copy link
Author

tbelway commented Feb 19, 2024

Any updates on getting this tested/merged? I run rootless podman and would really like this functionality. As it stands on the machine running rootless podman:

✓ Podman installation has been detected ! There is no Podman container of Pi-hole running ✗ Pi-hole was not found on this system » Status Report ✗ 1 critical issue(s) prevent successful deployment



CONTAINER ID  IMAGE                            COMMAND      CREATED         STATUS                   PORTS                                                                                                       NAMES
aa74381baf23  docker.io/mvance/unbound:latest  /unbound.sh  21 minutes ago  Up 21 minutes (healthy)  0.0.0.0:53->53/tcp, 0.0.0.0:80->80/tcp, 0.0.0.0:5335->5335/tcp, 0.0.0.0:53->53/udp, 0.0.0.0:5335->5335/udp  unbound
12c193d96ca1  docker.io/pihole/pihole:latest                21 minutes ago  Up 21 minutes (healthy)  0.0.0.0:53->53/tcp, 0.0.0.0:80->80/tcp, 0.0.0.0:5335->5335/tcp, 0.0.0.0:53->53/udp, 0.0.0.0:5335->5335/udp  pihole

I'm using it across three piholes at home, two of which are rootless podman one of which is a standard VM.
I've tested across:
fedora/almalinux VM rootless podman (I've done both)
microOS rootless podman (does have an odd bug where sometimes the gravity.db corrupts, but I'm pretty sure I've narrowed down the root cause. This happens regardless of if I'm using gravity-sync or not.
Ubuntu standard install.

Feel free to test it out for yourself and see if you have issues :) You could always help out vmstan by reporting your feedback too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants