Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image: Pihole + gravity-sync + openssh-server in one image, named 'sync-hole' #386

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

systemofapwne
Copy link
Contributor

@systemofapwne systemofapwne commented Mar 4, 2023

This PR includes changes, that will bundles the following into one single docker image.

  • pihole
  • gravity-sync
  • openssh-server

With these packages combined, it becomes a drop-in replacement for pihole. Syncing pihole never was easier!

I named this bundle sync-hole.

Documentation has been added and the current docker-image is 100% compatible to 'classic' gravity-sync setups.

NOTE: This PR relies also on the changes of my previous PR: #384 but might already be in this PR. I suggest, you first accept the other PR before this one here.
NOTE: Since my container requires the mentioned PR changes above, I have changed the upstream url in /etc/gravity-sync/.gs via the Dockerfile to my own gravity-sync fork. Please remove the following line, when you accept both PRs: https://github.com/systemofapwne/gravity-sync/blob/eef56b1922d44c1354c2d082a095de8ebcbfa4f9/docker/Dockerfile#L8

It would also be extremely nice, if you could supply an "official" sync-hole image to dockerhub.

If you think, that these changes are too much for your project, that so far only is about gravity-sync and not about bundling it with pihole & openssh-server via a docker image: Let me know! I would then start a dedicated repo with CI against automated generation of images to dockerhub. But IMHO, this project here should be available fully dockerized and bundled with pihole.

@wblew
Copy link
Contributor

wblew commented Apr 17, 2023

Very nice work!

@zenzip
Copy link

zenzip commented Nov 28, 2023

would be great include unbound also in this bundle, would be perfect!

@systemofapwne
Copy link
Contributor Author

systemofapwne commented Nov 28, 2023

Is unbound now part of official PiHole? If not, you can build your own docker container derived from this one and add unbound on top of it. Or even better: Build a secondary docker container just for unbound that either uses this piHole container as source (or feeds this docker container as primary DNS). The later option even comes closer to the unix philosophy of 'one program, one job'.

@holly79
Copy link

holly79 commented Feb 8, 2024

I used the code from @systemofapwne and it works like a charm. Thanks @systemofapwne !

I hope that your PR will be merged and other users will be able to use it more easily.

@github-cli
Copy link

looking forward to this... installing on one of the systems itself is not an option for me

@Jarsky
Copy link

Jarsky commented Apr 14, 2024

I wouldnt include unbound in this package either; Its extremely easy to spin up an Unbound docker.
If youre using Docker Swarm or Kubernetes just have multiple images in the stack to deploy together.
Not everyone is using Unbound either; personally im using Cloudflared so it would be a pain/redundant to have Unbound in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants