-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image: Pihole + gravity-sync + openssh-server in one image, named 'sync-hole' #386
base: master
Are you sure you want to change the base?
Conversation
…ty-sync.conf (if set) when calling 'gravity-sync config NEW_SSH_PORT'. Docker enhancements: Made many config-variables settable via ENV vars
Very nice work! |
would be great include unbound also in this bundle, would be perfect! |
Is unbound now part of official PiHole? If not, you can build your own docker container derived from this one and add unbound on top of it. Or even better: Build a secondary docker container just for unbound that either uses this piHole container as source (or feeds this docker container as primary DNS). The later option even comes closer to the unix philosophy of 'one program, one job'. |
I used the code from @systemofapwne and it works like a charm. Thanks @systemofapwne ! I hope that your PR will be merged and other users will be able to use it more easily. |
looking forward to this... installing on one of the systems itself is not an option for me |
I wouldnt include unbound in this package either; Its extremely easy to spin up an Unbound docker. |
This PR includes changes, that will bundles the following into one single docker image.
With these packages combined, it becomes a drop-in replacement for pihole. Syncing pihole never was easier!
I named this bundle
sync-hole
.Documentation has been added and the current docker-image is 100% compatible to 'classic' gravity-sync setups.
NOTE: This PR relies also on the changes of my previous PR: #384 but might already be in this PR. I suggest, you first accept the other PR before this one here.
NOTE: Since my container requires the mentioned PR changes above, I have changed the upstream url in /etc/gravity-sync/.gs via the Dockerfile to my own gravity-sync fork. Please remove the following line, when you accept both PRs: https://github.com/systemofapwne/gravity-sync/blob/eef56b1922d44c1354c2d082a095de8ebcbfa4f9/docker/Dockerfile#L8
It would also be extremely nice, if you could supply an "official"
sync-hole
image to dockerhub.If you think, that these changes are too much for your project, that so far only is about
gravity-sync
and not about bundling it with pihole & openssh-server via a docker image: Let me know! I would then start a dedicated repo with CI against automated generation of images to dockerhub. But IMHO, this project here should be available fully dockerized and bundled with pihole.