fix invalid cursor states and visual selection issues #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deleting lines, the cursor is moved to a valid position consistent with the hjkl movement limits. E.g., after deleting the last line with dd, it moves up one line. This furthermore prevents the internal start index of the visual selection to be decreased past zero and makes delete and yank of the visual selection work when the selection is expanded from the bottom, i.e., the start is below the end.
|
@medvednikov what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that pressing dd on the last line twice would make the program crash and made changes to prevent the cursor staying in invalid positions after dd and deletion of a visual selection.
As I found it hard to test these things separately, this also changes the behavior of visual selections such that selections with starting line below end line can be yanked/deleted and prevents the internal end position of the selection to go negative.