Allow hiding/unhiding the bar with SIGUSR1/2 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This seems to have some side-effects that I don't understand yet, will work on cleaning them up if this is of interest.) |
|
Fixed the side-effects, I was hiding things one level too deep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is something you'd actually want to upstream, but I'm posting it for consideration. This allows you to hide all blocks on the bar with SIGUSR1 and restore them with SIGUSR2. It doesn't actually prevent the blocks from updating, so there's no stale information when they are unhidden.
My usecase is temporarily making swaybar invisible without changing its height, so I can draw a transparent bemenu into the space. When bemenu closes, I restore the contents of the bar.
The rationale for splitting hide/show into separate signals is to allow an external script to do state tracking if necessary. If the hidden state was instead toggled with a single signal, you risk it getting out of sync with the calling script.