Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix warnings #357

wants to merge 4 commits into from

Commits on Aug 5, 2019

  1. block, json, log: fix different signedness comparisons 

    This fixes 2 comparisons between different signedness integers.

The first one is the signal type defined in block structure. In C,
signal numbers are defined as int. This commit fixes the definition in
block.h.

The second one is a comparison between and int and an enum. The
comparison requires the enum to be caseted in int.

The third one is the comparison between the result of snprintf()(ie.
int) and a sizeof variable (ie. size_t). This comparison requires the
int to be casted in unsigned, since the if statement ensures that the
value is not negative. This commit casts the int variable in size_t when
it is compared to a size_t.
    @gportay
    gportay committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    aaa9cc0 View commit details
    Browse the repository at this point in the history

  2. block: remove unused variable err 

    The variable err is unused in functions block_send and block_setup.
    @gportay
    gportay committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    341d4f3 View commit details
    Browse the repository at this point in the history

  3. block, ini, json: fix unused parameter 

    This fixes several unused parameters using the common method:

	(void)the_unused_parameter;
    @gportay
    gportay committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    17d9b60 View commit details
    Browse the repository at this point in the history

  4. autotools: compile against -Wall -Wextra and -Werror

    @gportay
    gportay committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    4163bd4 View commit details
    Browse the repository at this point in the history