Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first support for the dbaccelerator (faster get_multi) #284

Merged
merged 2 commits into from Jun 21, 2021

Conversation

tsteinruecken
Copy link
Contributor

@tsteinruecken tsteinruecken commented May 20, 2021

in response to googleapis/python-datastore#150
The original implementation of google.cloud.datastore currently has a major performance regression. We could work around it by adding support for the experimental datastore REST-API wrapper from https://github.com/viur-framework/dbaccelerator and use it for db.get and db.queries if not run inside a transaction

@tsteinruecken tsteinruecken added bug(fix) Something isn't working or address a specific issue or vulnerability dependencies Pull requests that update a dependency file labels May 20, 2021
@tsteinruecken tsteinruecken self-assigned this May 20, 2021
@xnopasaranx xnopasaranx marked this pull request as ready for review May 21, 2021 09:44
xnopasaranx
xnopasaranx previously approved these changes May 21, 2021
Copy link
Member

@xnopasaranx xnopasaranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great to have as soon as possible. Performance right now is just not excusable and since google won't fix it... I have seen the speed gains this brings on a testing setup.

skoegl
skoegl previously approved these changes Jun 11, 2021
@tsteinruecken tsteinruecken dismissed stale reviews from skoegl and xnopasaranx via 69687e1 June 21, 2021 13:46
@tsteinruecken tsteinruecken merged commit 49813b6 into master Jun 21, 2021
@tsteinruecken tsteinruecken deleted the feature/dbAccelerator branch June 21, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants