Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'More Color Tables' option to ColorTableButton #19504

Merged
merged 12 commits into from
May 20, 2024

Conversation

biagas
Copy link
Contributor

@biagas biagas commented May 8, 2024

Description

It will in turn call the OpenColorTable slot in the gui.

Resolves #17797

Updated section of Pseudocolor Plot docs with new color table button image and modified text to indicate usage of the new option
.
The docs update also includes mods to one-sentance-per-line, per our format specs.

Type of change

  • [ ] Bug fix
  • New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

Tested on Windows and Linux, Clicking a color table button shows the new option, and clicking it opens the Color Table window.

Checklist:

  • I have commented my code where applicable.
  • I have updated the release notes.
  • I have made corresponding changes to the documentation.~~
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.

It will in turn call the OpenColorTable slot in the gui.
@biagas biagas changed the base branch from develop to 3.4RC May 8, 2024 22:35
@biagas biagas changed the base branch from 3.4RC to develop May 8, 2024 22:36
@biagas
Copy link
Contributor Author

biagas commented May 8, 2024

@JustinPrivitera When you have time can you take this for a spin, see if this is what your were thinking.

@JustinPrivitera
Copy link
Member

That's awesome!

@biagas
Copy link
Contributor Author

biagas commented May 14, 2024

@JustinPrivitera should this go on 3.4RC ?

@JustinPrivitera
Copy link
Member

@JustinPrivitera should this go on 3.4RC ?

@biagas I think yes. We've had enough folks bring up missing color tables that I think having this in our next patch release would go a long way towards stopping the bleeding.

@biagas
Copy link
Contributor Author

biagas commented May 14, 2024

Do you think this image and docs should be updated? Changing the color table

@markcmiller86
Copy link
Member

It does not look like any state objects are changed so its probably ok on the RC.

@JustinPrivitera
Copy link
Member

Do you think this image and docs should be updated? Changing the color table

I think yes. I can do that if you'd like. Sorry this keeps expanding into more work!

@markcmiller86
Copy link
Member

I think yes. I can do that if you'd like. Sorry this keeps expanding into more work!

FWIW...I was thinking just an update of that screen capture to include the new top line option and an additional sentence about what that options means and maybe why its useful (e.g. default selection may not be appropriate) would be sufficient.

@markcmiller86
Copy link
Member

@JustinPrivitera...so....what does the 🚀 emoji mean?

@JustinPrivitera
Copy link
Member

I think yes. I can do that if you'd like. Sorry this keeps expanding into more work!

FWIW...I was thinking just an update of that screen capture to include the new top line option and an additional sentence about what that options means and maybe why its useful (e.g. default selection may not be appropriate) would be sufficient.

I agree with @markcmiller86

@JustinPrivitera...so....what does the 🚀 emoji mean?

Blasting off? Hooray? Innovation? I don't know but it's more fun than thumbs up so I try to throw it in sometimes

Update description of usage to include  `More Color Tables ...`.
Modified to one-sentence-per-line.
@biagas biagas marked this pull request as ready for review May 16, 2024 18:37
Copy link
Member

@JustinPrivitera JustinPrivitera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

src/resources/help/en_US/relnotes3.4.2.html Outdated Show resolved Hide resolved
Co-authored-by: Justin Privitera <35237779+JustinPrivitera@users.noreply.github.com>
Copy link
Member

@JustinPrivitera JustinPrivitera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @biagas!

@biagas biagas merged commit 9bebf40 into develop May 20, 2024
4 checks passed
@biagas biagas deleted the task/biagas/connect_colortablebutton_colortablewindow branch May 20, 2024 19:35
biagas added a commit that referenced this pull request May 20, 2024
Port of changes in develop(#19504)  to 3.4RC.
biagas added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Table Button Should Link Back to Color Table Manager
3 participants