-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'More Color Tables' option to ColorTableButton #19504
Add 'More Color Tables' option to ColorTableButton #19504
Conversation
It will in turn call the OpenColorTable slot in the gui.
@JustinPrivitera When you have time can you take this for a spin, see if this is what your were thinking. |
That's awesome! |
@JustinPrivitera should this go on 3.4RC ? |
@biagas I think yes. We've had enough folks bring up missing color tables that I think having this in our next patch release would go a long way towards stopping the bleeding. |
Do you think this image and docs should be updated? Changing the color table |
It does not look like any state objects are changed so its probably ok on the RC. |
I think yes. I can do that if you'd like. Sorry this keeps expanding into more work! |
FWIW...I was thinking just an update of that screen capture to include the new top line option and an additional sentence about what that options means and maybe why its useful (e.g. default selection may not be appropriate) would be sufficient. |
@JustinPrivitera...so....what does the 🚀 emoji mean? |
I agree with @markcmiller86
Blasting off? Hooray? Innovation? I don't know but it's more fun than thumbs up so I try to throw it in sometimes |
Update description of usage to include `More Color Tables ...`. Modified to one-sentence-per-line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great!
Co-authored-by: Justin Privitera <35237779+JustinPrivitera@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @biagas!
Port of changes in develop(#19504) to 3.4RC.
Port of changes in develop(#19504) to 3.4RC.
Description
It will in turn call the OpenColorTable slot in the gui.
Resolves #17797
Updated section of Pseudocolor Plot docs with new color table button image and modified text to indicate usage of the new option
.
The docs update also includes mods to one-sentance-per-line, per our format specs.
Type of change
[ ] Bug fix[ ] Documentation update[ ] OtherHow Has This Been Tested?
Tested on Windows and Linux, Clicking a color table button shows the new option, and clicking it opens the Color Table window.
Checklist:
[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.