Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shadertools): Fix ../.. imports #2054

Merged
merged 1 commit into from Mar 27, 2024
Merged

fix(shadertools): Fix ../.. imports #2054

merged 1 commit into from Mar 27, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 27, 2024

For visgl/deck.gl#8711

Background

  • Broken '../..' import, probably injected by vscode.

Change List

  • Fix the import

Notes

  • There seem to be two more cases on the release branch that have already been fixed on master, will make a separate PR for those.

@ibgreen ibgreen marked this pull request as ready for review March 27, 2024 10:21
@ibgreen ibgreen merged commit c1ff9b8 into 9.0-release Mar 27, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/fix-dotdot-import branch March 27, 2024 16:08
@Pessimistress Pessimistress mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @Pessimistress