fix(webgl): Pair calls to bind/unbind VAO

[donmccurdy]

Fixes:

• https://felixpalmer.github.io/deck.gl/examples/tile-layer
• https://felixpalmer.github.io/deck.gl/examples/tile-layer-non-geospatial

It's not obvious to me that we should be able to bind the index buffer only once... if not, we need to bind on every frame.

Related:

• [Bug] Broken website examples in 9.0.0-beta.10 deck.gl#8582

[donmccurdy]

• fix(webgl): Pair calls to bind/unbind VAO #2032 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donmccurdy and the rest of your teammates on Graphite

[ibgreen]

If the index buffer is not stored in the underlying VertexArray, then one could question whether it should be managed by the VertexArray class.

[donmccurdy]

On closer look at the spec, I think I see the issue – will try to bump this to avoid rebinding on each frame.

[donmccurdy]

Done! I think the trick here will be to pair every call to bindVertexArray(vao) with a later call to bindVertexArray(null), to make sure nothing modifies our VAO unintentionally. With that, we can do the index buffer binding once up front, as you'd intended.

[ibgreen]

Ok Let's land it and keep an eye on it. It will be great if this binding/unbinding can be remove.