fix(shadertools) attribute picking regression (#2059)

visgl · Apr 2, 2024 · 8ff77e9 · 8ff77e9
1 parent df577b1
commit 8ff77e9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/modules/shadertools/src/modules/engine/picking/picking.ts b/modules/shadertools/src/modules/engine/picking/picking.ts
@@ -95,10 +95,10 @@ void picking_setPickingColor(vec3 pickingColor) {
     // Use alpha as the validity flag. If pickingColor is [0, 0, 0] fragment is non-pickable
     picking_vRGBcolor_Avalid.a = float(picking_isColorValid(pickingColor));
 
-    // if (!bool(picking.isAttribute)) {
-    // Stores the picking color so that the fragment shader can render it during picking
-    picking_vRGBcolor_Avalid.rgb = pickingColor;
-    // }
+    if (!bool(picking.isAttribute)) {
+      // Stores the picking color so that the fragment shader can render it during picking
+      picking_vRGBcolor_Avalid.rgb = pickingColor;
+    }
   } else {
     // Do the comparison with selected item color in vertex shader as it should mean fewer compares
     picking_vRGBcolor_Avalid.a = float(isVertexHighlighted(pickingColor));