fix(pydeck): Fix cell height in Google Colab #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajduberstein
approved these changes
May 9, 2024
|
I was able to test the local changes in Colab, and the fix works well. I've added a section to the contributing documentation in this PR, explaining how to test local changes in Colab. |
donmccurdy
added a commit
that referenced
this pull request
May 23, 2024
* fix(pydeck): Fix cell height in Google Colab * docs(pydeck): Add documentation about testing local changes in Google Colab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using Pydeck in Google Colab, the
iframe_heightargument sets the minimum height, the iframe renders at that height, and then it incrementally becomes taller until reaching the maximum cell height allowed by colab, 1000px:colab_height_bug.webm
I believe this is the fix, but haven't found a way to test local builds against Google Colab environments yet. I'll look a bit more into that, and perhaps test on an alpha release if that's not possible. Perhaps there's also some CSS padding or margin contributing to the problem.
Change List