Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pydeck,pydeck-carto): Fix readthedocs builds #8871

Merged
merged 1 commit into from May 7, 2024

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented May 6, 2024

Docs for latest pydeck and pydeck-carto releases are now published, based on this PR:

Changes:

  • Copy active Python module to root directory before readthedocs build process
  • Pin and install sphinx theme
  • Skip broken Jupyter widget build, not required for docs
  • Remove binding/pydeck/pyproject.toml (invalid?) during documentation builds
  • Update version numbers (from Release: pydeck v0.9.0, pydeck-carto v0.2.0 #8855)

Notes:

I pushed this branch to github today, donmccurdy/pydeck-dev, and this time it did appear in the readthedocs dashboard's branch list. From that I was able to change settings in the readthedocs dashboard to deploy from this branch, push changes, and iteratively fix the issues above. I'm not sure why previous branches didn't appear in the dashboard.

After this PR is merged, the active branch in the readthedocs dashboards can be changed back to master.

@coveralls
Copy link

coveralls commented May 6, 2024

Coverage Status

coverage: 89.82% (-0.001%) from 89.821%
when pulling 12dd78e on donmccurdy/pydeck-dev
into ff9246e on master.

@donmccurdy donmccurdy merged commit 86f3f84 into master May 7, 2024
4 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/pydeck-dev branch May 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc pydeck python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants