fix(carto): Fix broken encoding in POST requests #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
May 3, 2024
felixpalmer
reviewed
May 6, 2024
| @@ -45,7 +45,7 @@ export const vectorTableSource = async function ( | |||
| urlParameters.columns = columns.join(','); | |||
There was a problem hiding this comment.
I wonder if the API should accept columns as JSON also, would be nicer not to special case it
felixpalmer
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues occurring when URL lengths exceed the limit for GET requests, and we switch to POST requests.
DEFAULT_PARAMETERSare applied the same way for GET and POST requestsJSON.stringify()encoding in*QuerySource()and*TableSource()functions, because we don't know yet whether the request will be GET or POST. Ensure thatrequestWithParametersapplies the necessary string encoding (for GET requests only) instead.