chore(pydeck): Disable broken Jupyter bindings in v0.9 #8854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Apr 29, 2024
ibgreen
reviewed
Apr 29, 2024
| @@ -16,5 +16,8 @@ def test_nbconvert(): | |||
| # NOTE skipping 03 (which contains live singapore taxi data) until I can provide a static version of that data | |||
| if "04" in fname or "06" in fname or "03" in fname: | |||
| continue | |||
| # NOTE Jupyter-specific features not currently supported in pydeck v0.9. | |||
| if "01" in fname or "02" in fname: | |||
There was a problem hiding this comment.
The previously skipped ones no longer need to be skipped?
There was a problem hiding this comment.
Not sure I follow, sorry!
Adding two tests to the list of skipped tests here, failing for the disabled .update() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter bindings are not currently working in pydeck, and won't make it into the pydeck v0.9 release. To make this less disorienting for users, I've made two changes here:
.show()should call.to_html()automatically, as it would in Colab or other environments.update()should show a warningThis can certainly be revisited in upcoming releases, as we consider what to do about two-way bindings.