Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): explicitly set clearStencil in LayersPass #8844

Merged
merged 1 commit into from Apr 26, 2024

Conversation

Pessimistress
Copy link
Collaborator

Closes #8602

v8 -> v9 the undefined behavior changed to always clear

Change List

  • Explicitly set clearStencil in LayersPass

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ever using stencils?

@Pessimistress
Copy link
Collaborator Author

@ibgreen Are we ever using stencils?

Maplibre is, hence the breakage in interleaved mode

@coveralls
Copy link

Coverage Status

coverage: 90.025% (+0.001%) from 90.024%
when pulling 60d5a09 on x/maplibre-fix
into e823e40 on master.

@Pessimistress Pessimistress merged commit ab3b018 into master Apr 26, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/maplibre-fix branch April 26, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[maplibre] checkerboard rendering regression when interleaved: true
3 participants