Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pydeck-carto): Update H3, Quadbin, and styling examples for deck.gl v9 #8806

Merged
merged 3 commits into from Apr 17, 2024
Merged

feat(pydeck-carto): Update H3, Quadbin, and styling examples for deck.gl v9 #8806

merged 3 commits into from Apr 17, 2024

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Apr 17, 2024 •
edited

PR targets branch of #8577.

Changes:

  • add make test-scripts macro for quickly testing pydeck-carto examples
  • update example scripts to output HTML in the scripts directory, for testing with npx serve
  • update H3, quadbin, and styling examples for deck v9
  • miscellaneous fixes for CARTO sources in pydeck-carto

@donmccurdy donmccurdy requested a review from Jesus89 April 17, 2024 19:15
@donmccurdy donmccurdy changed the title feat(pydeck-carto): Update H3 examples for deckgl v9 feat(pydeck-carto): Update H3, Quadbin, and styling examples for deck.gl v9 Apr 17, 2024
donmccurdy
donmccurdy commented Apr 17, 2024
View reviewed changes
bindings/pydeck-carto/pydeck_carto/sources.py
@@ -144,17 +163,19 @@ class VectorTilesetSourceOptions(TilesetSourceOptions):
def vector_table_source(**kwargs: Unpack[VectorTableSourceOptions]):
return pdk.types.Function(
"vectorTableSource", **{**column_options(**kwargs), **table_options(**kwargs)}
)
).serialize() # TODO Required?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably this serialization should be handled somewhere on the pydeck side, but from the user's perspective this is an invisible workaround. I'm nervous to make a serialization change to pydeck, so I think I prefer this workaround for now.

@donmccurdy donmccurdy merged commit e9c1a94 into jarroyo/pydeck-carto-v9 Apr 17, 2024
4 checks passed
@donmccurdy donmccurdy deleted the donmccurdypydeck-carto-v9-h3-sources branch April 17, 2024 19:55
donmccurdy added a commit that referenced this pull request Apr 26, 2024
@Jesus89 @donmccurdy
feat(pydeck): Support Deck v9 in bindings (#8577)
9be0e4a 
* feat(pydeck): Update to Deck v9
* feat(pydeck-carto): Add new CARTO layers, sources, and auth flow (#8791, #8806)

---------

Co-authored-by: Don McCurdy <donmccurdy@cartodb.com>
donmccurdy added a commit that referenced this pull request Apr 29, 2024
@Jesus89 @donmccurdy
feat(pydeck): Support Deck v9 in bindings (#8577)
c3cd79a 
* feat(pydeck): Update to Deck v9
* feat(pydeck-carto): Add new CARTO layers, sources, and auth flow (#8791, #8806)

---------

Co-authored-by: Don McCurdy <donmccurdy@cartodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus89 Jesus89 Awaiting requested review from Jesus89

Assignees
No one assigned
Labels
feature pydeck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@donmccurdy