feat(pydeck-carto): Implement Deck v9 sources and type validation #8791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
Apr 16, 2024
|
Merging to feature branch. |
donmccurdy
added a commit
that referenced
this pull request
Apr 26, 2024
donmccurdy
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the pydeck-carto module with support for all source types, along with basic input validation and type checking.
I don't yet have the ability to test this PR within an interactive Jupyter environment. If it would be better to exhaustively write parameters for all functions rather than using TypedDict — does this method support autocomplete in Jupyter? — then I'm happy to make that change.