Fix picking bugs #8730
Merged
Fix picking bugs #8730
+115
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/picking-fix
branch
from
bdc99e4
to
55969fa
Compare
Pessimistress
force-pushed
the
x/picking-fix
branch
from
1b67610
to
17c9844
Compare
Pessimistress
force-pushed
the
x/picking-fix
branch
from
17c9844
to
a9eaaca
Compare
felixpalmer
approved these changes
Apr 2, 2024
| }) | ||
| ] | ||
| colorAttachments: ['rgba32float'], | ||
| depthStencilAttachment: 'depth16unorm' | ||
| }); | ||
| this.depthFBO = depthFBO; |
There was a problem hiding this comment.
I wonder if we can come up with a better name than depthFBO, I find it a bit confusing
ibgreen
approved these changes
Apr 2, 2024
| pickParameters.blend = false; | ||
| } else if (pickable && operation.includes('draw')) { | ||
| Object.assign(pickParameters, PICKING_BLENDING); |
There was a problem hiding this comment.
Nit: A bit terse. Maybe call them PICKING_BLEND_PARAMETERS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8704
Fixing various issues with DeckPicker
Change List
blend*device parameters are set, they override theblend: falseGL parameter. This is unfortunately very hard to debug as device parameter is set deeply insidepipeline.draw. I really hope we can get rid of GL parameters soon...