Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aggregation-layers): Fix missing types export #8713

Merged
merged 2 commits into from Mar 27, 2024

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Mar 27, 2024

The public API of the aggregation-layers module depends on a type that isn't exported from the core module. I've made the quick fix here to export that type, resolving the error:

 node_modules/@deck.gl/aggregation-layers/dist/aggregation-layer.d.ts:16:29:
   16 │ ...ring]: import("modules/core/src/lib/attribute/attribute").default;
      ╵                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This PR changes the the compiled types in aggregation-layer.d.ts:

-    getAttributes(): {
-        [id: string]: import("modules/core/src/lib/attribute/attribute").default;
-    };
+    getAttributes(): {
+        [id: string]: Attribute;
+    };

But this looks like the type of issue that could also possibly be fixed by a TS update or some of the types error detection that API-Extractor provides, if we want to go that direction.

Related:

@donmccurdy
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donmccurdy and the rest of your teammates on Graphite Graphite

@coveralls
Copy link

Coverage Status

coverage: 89.975% (+0.001%) from 89.974%
when pulling e46d303 on donmccurdy/fix-types-aggregation-layer-attributes
into d9a78da on master.

@donmccurdy donmccurdy merged commit a4fb740 into master Mar 27, 2024
4 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/fix-types-aggregation-layer-attributes branch March 27, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants