Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute transition #8643

Merged
merged 13 commits into from Mar 13, 2024
Merged

Fix attribute transition #8643

merged 13 commits into from Mar 13, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Attribute transition is working again (#8582 highway example, scenegraph example)

Change List

  • Update GPU transition logic to v9 buffer layout / render pass pattern
  • Light refactor for better code readability
  • Add types and documentation in comments to core/transitions
  • Update test/apps/attribute-transition for local debugging
  • Enable render tests

model.setUniforms({time: t});
// @ts-ignore
const gl = model.device.gl as WebGL2RenderingContext;
// TODO - remove after https://github.com/visgl/luma.gl/pull/2023
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on a patch with visgl/luma.gl#2023

@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 84.082% (+0.2%) from 83.911%
when pulling 170890b on x/attribute-transition
into 3bb7fb3 on master.

Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the locally (overriding countRange = [5, 5]) and I get some strange artifacts:

Screen.Recording.2024-03-13.at.11.35.09.mov

modules/core/src/lib/attribute/data-column.ts Outdated Show resolved Hide resolved
@Pessimistress
Copy link
Collaborator Author

@felixpalmer I can't reproduce it. Maybe you have outdated cache of luma locally? Try yarn start-local --force

Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a 'spring' transition completes, it continues to shift very slightly, indefinitely, perhaps we aren't detecting when a spring transition completes?

spring_transition_flicker.mov

This is such a huge improvement though – I don't think that should block anything.

The refactoring here is great, thank you! 🚀

@Pessimistress Pessimistress merged commit 89189f4 into master Mar 13, 2024
3 checks passed
@Pessimistress Pessimistress deleted the x/attribute-transition branch March 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants