New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attribute transition #8643
Fix attribute transition #8643
Conversation
model.setUniforms({time: t}); | ||
// @ts-ignore | ||
const gl = model.device.gl as WebGL2RenderingContext; | ||
// TODO - remove after https://github.com/visgl/luma.gl/pull/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on a patch with visgl/luma.gl#2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the locally (overriding countRange = [5, 5]
) and I get some strange artifacts:
Screen.Recording.2024-03-13.at.11.35.09.mov
@felixpalmer I can't reproduce it. Maybe you have outdated cache of luma locally? Try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a 'spring' transition completes, it continues to shift very slightly, indefinitely, perhaps we aren't detecting when a spring transition completes?
spring_transition_flicker.mov
This is such a huge improvement though – I don't think that should block anything.
The refactoring here is great, thank you! 🚀
For #7457
Attribute transition is working again (#8582 highway example, scenegraph example)
Change List