Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointCloudLayer colors attribute type use 'unorm8' #8633

Merged
merged 2 commits into from Mar 12, 2024
Merged

PointCloudLayer colors attribute type use 'unorm8' #8633

merged 2 commits into from Mar 12, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #8582, fixes regression from #8572

It may be worth considering updating the format emitted from loaders.gl @ibgreen to avoid passing GL constants

Background

Change List

  • PointCloudLayer colors attribute type use 'unorm8'

@felixpalmer felixpalmer mentioned this pull request Mar 12, 2024
Closed
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited

Coverage Status

coverage: 82.898%. remained the same
when pulling 6bbe09b on felix/fix-point-cloud-vertex-type
into a670a0f on master.

@felixpalmer felixpalmer merged commit 09cca5e into master Mar 12, 2024
3 checks passed
@felixpalmer felixpalmer deleted the felix/fix-point-cloud-vertex-type branch March 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixpalmer @coveralls @donmccurdy