Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp Uint8Arrays in typedArrayFromDataType #8631

Merged
merged 3 commits into from Mar 13, 2024
Merged

Clamp Uint8Arrays in typedArrayFromDataType #8631

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b359f01
Clamp uint8arrays as we did in v8
felixpalmer Mar 12, 2024
2d67aea
Comments
felixpalmer Mar 12, 2024
21a606a
Merge branch 'master' into felix/vertextype-clamped
felixpalmer Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/core/src/lib/attribute/gl-utils.ts
View file
Open in desktop
Expand Up @@ -9,7 +9,11 @@ export function typedArrayFromDataType(type: LogicalDataType): TypedArrayConstru
case 'float64':
return Float64Array;
default:
return getTypedArrayFromDataType(type);
const typedArray = getTypedArrayFromDataType(type);
if (typedArray === Uint8Array) {
return Uint8ClampedArray;
}
return typedArray;
felixpalmer marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down