chore(carto): Improve test coverage #8629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @donmccurdy and the rest of your teammates on |
felixpalmer
approved these changes
Mar 12, 2024
donmccurdy
force-pushed
the
donmccurdy/chore-carto-test-coverage-20240311
branch
from
a268903
to
9d959ab
Compare
donmccurdy
force-pushed
the
donmccurdy/chore-carto-test-coverage-20240311
branch
from
9d959ab
to
3ecb3ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I've opted to put map configs inline with the tests here, rather than keeping the external JSON files. I find it easier to debug test failures this way, and we get the benefit of TypeScript checks on the test assertions.
Related: