New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore layer tests #8597
Restore layer tests #8597
Conversation
b285b46
to
e310bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage: 📈
// TODO v9 gltf dependent layers | ||
// import './simple-mesh-layer.spec'; | ||
// import './scenegraph-layer.spec'; | ||
import './simple-mesh-layer.spec'; | ||
import './scenegraph-layer.spec'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: looks like the TODO above can be removed!
layer.state.model.getUniforms().radiusScale, | ||
layer.getModels()[0].uniforms.radiusScale, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is layer.getModels()
now universally preferred over layer.state.model
?
For #8592
Change List