Audit module dependencies #8573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/package-audit
branch
from
7a39556
to
8cbd35e
Compare
Pessimistress
commented
Mar 2, 2024
| @@ -40,6 +40,7 @@ | |||
| "@loaders.gl/core": "^4.1.0", | |||
| "@loaders.gl/csv": "^4.1.0", | |||
| "@luma.gl/core": "9.0.0-beta.4", | |||
| "d3-dsv": "^1.0.8", | |||
There was a problem hiding this comment.
@loaders.gl/csv is missing this dependency @ibgreen
Pessimistress
force-pushed
the
x/package-audit
branch
2 times, most recently
from
7120232
to
6347bad
Compare
Pessimistress
force-pushed
the
x/attribute-type
branch
from
1448a5d
to
6927e36
Compare
ibgreen
approved these changes
Mar 5, 2024
| "@luma.gl/shadertools": "9.0.0-beta.4", | ||
| "@math.gl/web-mercator": "^4.0.0", | ||
| "d3-hexbin": "^0.2.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "@deck.gl/core": "^9.0.0-alpha", | ||
| "@deck.gl/layers": "^9.0.0-alpha", | ||
| "@luma.gl/core": "9.0.0-beta.4", | ||
| "@luma.gl/engine": "9.0.0-beta.4" | ||
| "@luma.gl/core": "^9.0.0-beta", |
There was a problem hiding this comment.
Users don't have to explicitly specify luma deps right? they are covered by deck.gl/core or something? Why is shadertools handled differently?
There was a problem hiding this comment.
Technically the only package that has to go into peer dep is core, which does not allow multiple copies.
| @@ -509,20 +520,20 @@ export default class DataColumn<Options, State> { | |||
| // https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/vertexAttribPointer | |||
| normalizeConstant(value: NumericArray): NumericArray { | |||
There was a problem hiding this comment.
Should this always return a Float32Array?
If we are using luma.gl types, should this be a luma.gl utility?
Pessimistress
force-pushed
the
x/package-audit
branch
from
6347bad
to
7bbdd24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
Change List