chore(build): restore inline-webgl-constants transform #8563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Feb 29, 2024
Pessimistress
force-pushed
the
x/inline-webgl-constants
branch
from
cac8cc5
to
aa176af
Compare
Pessimistress
force-pushed
the
x/inline-webgl-constants
branch
from
aa176af
to
fa17c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
There still are some WebGL specific code scattered around, e.g. various blending modes. Including the
@luma.gl/constantsmodule adds about 60k (33k minified) to a bundle.Change List