chore(mapbox) use props.device instead of props.gl #8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gervang <chris@gervang.com>
felixpalmer
approved these changes
Feb 28, 2024
| @@ -50,7 +51,7 @@ export function getDeckInstance({ | |||
|
|
|||
| let deckInstance: Deck; | |||
|
|
|||
| if (!deck || deck.props.gl === gl) { | |||
| if (!deck || (deck.props.device instanceof WebGLDevice && deck.props.device.gl === gl)) { | |||
There was a problem hiding this comment.
I assume the instanceof check here is just to keep Typescript happy? What happens if it is a WebGPUDevice? Would it maybe be safer to check for WebGPUDevice at the start of this function and exit early with a warning?
Pessimistress
requested changes
Feb 28, 2024
| @@ -50,7 +51,7 @@ export function getDeckInstance({ | |||
|
|
|||
| let deckInstance: Deck; | |||
|
|
|||
| if (!deck || deck.props.gl === gl) { | |||
| if (!deck || (deck.props.device instanceof WebGLDevice && deck.props.device.gl === gl)) { | |||
There was a problem hiding this comment.
This will break the check. Note you are checking deck.props which is constructed below at line 59. Only gl is passed, not device.
Pessimistress
force-pushed
the
master
branch
4 times, most recently
from
0a083b6
to
eb85da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8553
Change List
props.device