Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-utils typescript errors #8483

Merged
merged 2 commits into from Feb 9, 2024
Merged

Fix test-utils typescript errors #8483

merged 2 commits into from Feb 9, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Change List

  • Type everything in test-utils
  • Replace chained promised with async/await
  • Enable test-utils build

felixpalmer
felixpalmer approved these changes Feb 9, 2024
View reviewed changes
modules/test-utils/src/snapshot-test-runner.ts
}
});
}
runTestCase(testCase: SnapshotTestCase) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use async like here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deck's render event is callback based.

@Pessimistress Pessimistress merged commit 2737b0a into master Feb 9, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/test-utils-ts branch February 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @felixpalmer