Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce webgl module imports #8472

Merged
merged 2 commits into from Feb 6, 2024
Merged

chore: Reduce webgl module imports #8472

merged 2 commits into from Feb 6, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Feb 5, 2024

For #7457

Background

  • Goal is to remove all direct access to the WebGL module

Change List

  • Replace readPixels import with new device method
  • For now, the new Device method only works on WebGL but at least let's us break the import dependency.

Most of the remaining imports related to GLParameters. We could offer similar methods on the device (e.g. device.setGLParameters()) to remove those.

@ibgreen ibgreen marked this pull request as ready for review February 5, 2024 18:47
@ibgreen ibgreen merged commit eb44d5e into master Feb 6, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/remove-webgl-imports branch February 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants