[RFC] ColorFilterExtension

[chrisgervang]

For #

Background

This RFC proposes a new layer extension for deck.gl that allows users to easily apply color filters and effects, such as tint, brightness, and saturation, to any layer. The extension utilizes the getModels function from each layer and injects a DECKGL_FILTER_COLOR shader extension into each model.

Try it out here.

Change List

• RFC

[felixpalmer]

I would prefer just one extension and instead a list of effects

new ColorFilterExtension([hueSaturation, brightnessContrast])

[felixpalmer]

By importing the module you can easily obtain the props required using Typescript:

brightnessContrast: {
  brightness: 0.5,
  contrast: 0.5
} as typeof brightnessContrast.props

[felixpalmer]

For me this is too limiting. I don't find importing a shader module from luma and passing it to the ColorFilterExtension constructor too onerous. It is also what we already have in the PostProcessEffect

[felixpalmer]

PostProcessEffect has the props passed directly to the constructor. What do you think of the pattern:

new ColorFilterExtension(brightnessContrast, {
  brightness: 0.5,
  contrast: 0.5
})

Then with types with would get autocompletion on the parameters:

 export default class ColorFilterExtension<T extends ShaderModule> extends LayerExtension {
   constructor(shaderModule: T, shaderModuleProps: T['props']) 
}

[felixpalmer]

My vote is for a variation on Design 1, allowing passing custom shader modules. I think being able to modify the shaders is really powerful and fun and not so difficult for basic color filters

[kylebarron]

Interesting! This is very similar to what I implemented in deck.gl-raster, where I had a set of shaders that would be compiled and passed in. I think that's similar to your first approach.