Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix ghcn website example #8242

Merged
merged 1 commit into from Oct 31, 2023
Merged

[website] Fix ghcn website example #8242

merged 1 commit into from Oct 31, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #8193

Background

Change List

  • Convert example to Typescript
  • Use MeshAttributes for borderMesh
  • Fix wireframe rendering in SimpleMeshLayer

@felixpalmer felixpalmer mentioned this pull request Oct 31, 2023
23 tasks
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: What on earth is ghcn? Do we have to have such a cryptic name? We are pretty strict with asking people to type out variable names - should we not apply at least a minimal similar standard for directories?

@felixpalmer
Copy link
Collaborator Author

felixpalmer commented Oct 31, 2023

@ibgreen it refers to the dataset, Global Historical Climatology Network. I'd be in favour of renaming examples/website/ghcn > examples/website/orthographic-view as it more useful to see what the example demonstrates rather than what it contains

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 31, 2023

I would vote for that. Should probably be separate PR, or open a ticket.

If breaking example perma-links are a concern, it is fairly easy to add redirects in docusaurus. https://github.com/visgl/math.gl/blob/master/website/docusaurus.config.js#L107

@felixpalmer felixpalmer merged commit 7f600c9 into master Oct 31, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/ghcn-fix branch October 31, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants