Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Fix SimpleMeshLayer #8201

Merged
merged 4 commits into from Oct 15, 2023
Merged

[v9] Fix SimpleMeshLayer #8201

merged 4 commits into from Oct 15, 2023

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Change List

  • Shader attribute returns the correct constant value
  • Replace mat3 with vec3x3 attributes in SimpleMeshLayer vertex shader (matrix attribute support is dropped in luma v9 and not supported by WebGPU)
  • Normalize geometry attributes by filling placeholder buffers (constant geometry attributes no longer supported in v9)
  • Drop _useMeshColors prop (already documented as to be removed in v9)
  • Restore TerrainLayer export
  • Enable SimpleMeshLayer and TerrainLayer render tests

@Pessimistress Pessimistress merged commit eaa106b into master Oct 15, 2023
2 checks passed
@Pessimistress Pessimistress deleted the x/mesh-layer-v9 branch October 15, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants