Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MaskExtension with HeatmapLayer #7397

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

felixpalmer
Copy link
Collaborator

For #7184

Background

Screen.Recording.2022-11-10.at.14.12.13.mov

Due to the aggregation the mask extension wasn't working with the HeatmapLayer. This PoC works well, but it doesn't fit cleanly with the deck architecture. @Pessimistress could you give some input on:

  • How to cleanly access the EffectManager in AggregationLayer.getModuleParameters
  • How best to get the weightsTransform to execute after the mask is rendered. I couldn't find a way without adding the postEffect hook

Change List

  • Provide correct uniforms to shaders in weightsTransform & TriangleLayer
  • Update shaders to work with extension

TODO

  • Agree on how to cleanly integrate
  • Revert changes to test app
  • Render tests

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layers should not have any knowledge of a particular extension. I believe that the transform (which generates the heatmap texture) is already created with the shader of the MaskExtension. The issue is that when the layer updates its module settings, parameters are only sent to the model that draws to screen, bypassing the transform.

@felixpalmer
Copy link
Collaborator Author

@Pessimistress

Layers should not have any knowledge of a particular extension.

This is difficult as the HeatmapLayer needs to behave differently depending on the value of maskByInstance. How can this be handled more cleanly?

The issue is that when the layer updates its module settings, parameters are only sent to the model that draws to screen, bypassing the transform.

I don't follow here, I'm not sure what change you want me to make

@andresramosp
Copy link

Hello, this is still in progress? any estimation of release? Thanks.

@alasarr alasarr added this to the 8.9 milestone Feb 2, 2023
@andresramosp
Copy link

Hello, sorry for asking again, is there any forecast to release this fix? In my company we need to mask the heatmap layer at port level very accurately and it would be nice to know if we can count on it or look for another solution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants