Fix examples url #7354
Open
Fix examples url #7354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marr
force-pushed
the
fix-examples-url
branch
from
ef58d15
to
03f6771
Compare
|
Could you split this into 2 PRs? The doc fix is easier to review, but I'm not sure about the other changes - on my M1 mac the build is working |
|
@felixpalmer Sure can. And about the test change: do tests pass for you without that change? |
|
@marr If I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some documentation improvements and bump node-canvas for build issues on Apple silicon.
Fixes #7352