Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] rename safegraph example to mapbox #8522

Closed
1 of 7 tasks
chrisgervang opened this issue Feb 23, 2024 · 2 comments · Fixed by #8558
Closed
1 of 7 tasks

[Bug] rename safegraph example to mapbox #8522

chrisgervang opened this issue Feb 23, 2024 · 2 comments · Fixed by #8558
Assignees
Labels

Comments

@chrisgervang
Copy link
Collaborator

chrisgervang commented Feb 23, 2024

Description

While working on #8146 I came across our safegraph example. Its one of our best examples for demonstrating interleaved basemap rendering with mapbox. For discoverability I think it should be renamed to mapbox. safegraph is the source of the data, however it's not super clear how it relates to mapbox.

Our website calls this example Mapbox: https://deck.gl/examples/mapbox

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

No response

Steps to Reproduce

Go to https://deck.gl/examples/mapbox click on "View Code"

Environment

  • Framework version:
  • Browser: Chrome
  • OS:

Logs

No response

@chrisgervang chrisgervang changed the title [Bug] rename safegraph example to mapbox [Bug] rename safegraph example to mapbox-interleaved Feb 23, 2024
@chrisgervang chrisgervang self-assigned this Feb 29, 2024
@chrisgervang chrisgervang changed the title [Bug] rename safegraph example to mapbox-interleaved [Bug] rename safegraph example to mapbox Feb 29, 2024
@chrisgervang
Copy link
Collaborator Author

@Pessimistress I'd like to do this rename to reduce confusion. Should I make a PR either move or add the example's data to a mapbox folder in https://github.com/visgl/deck.gl-data/tree/master/examples/ as well?

@chrisgervang
Copy link
Collaborator Author

Discussed offline with @Pessimistress: we're not going to touch deck.gl-data since that would break links on old branches. I will rename the example in deck to mapbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant